arina-ielchiieva commented on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-416534459 @oleg-zinovev besides comment in the PR I suggest a couple more things: 1. File a Jira for failed tests (indicating what and why fails - basically copy info from the PR description + indicate affected JDKs). 2. As I understand the purpose of this PR is allow build on JDK 9 and 10. Maybe it's better to rename commit message to highlight this. Description of the changes (which was really useful during the review, thanks for that!) can be included the commit message as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
