[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-30 Thread GitBox
cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r199336411 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.java #

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198850630 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.java #

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198850069 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunctions.java

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198845203 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunctions.java

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-27 Thread GitBox
cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198701570 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunctions.java