[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-05 Thread kr-arjun
Github user kr-arjun commented on the issue: https://github.com/apache/drill/pull/1011 @paul-rogers I was able to resolve this issue by workaround of setting 'yarn.timeline-service.enabled' to false ( Copied yarn-site.xml with this property set to $DRILL_SITE directory). Th

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-04 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 @arina-ielchiieva, thanks much for your help with this PR. Glad to see it is finally in Drill master after all this time! ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-04 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 @kr-arjun, thanks for the text file. The error is related to security. DoY, in its current for, is an "MVP": it works, but leaves off advanced features. One of those missing features is to work w

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-04 Thread kr-arjun
Github user kr-arjun commented on the issue: https://github.com/apache/drill/pull/1011 @paul-rogers The client error message changes look good. I did quick test with client error message changes and could verify that error message are logged. > Where you using the start comm

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-03 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 @arina-ielchiieva, turned out that there were unneeded dependencies in the DoY additions to the drill-root pom.xml file. Removed these and the json.org warnings went away. Please take a

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-03 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 Rebased onto latest master. ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-03 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 @kr-arjun, thanks for your note on error handling. Where you using the `start` command? There is exactly one place where the error "Failed to start Drill application master" is thrown: it is when

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1011 @paul-rogers when unit running tests with mapr profile, they fail because this commit bring banned dependency: `[INFO] --- maven-enforcer-plugin:1.3.1:enforce (avoid_bad_dependencies) @

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1011 @kr-arjun, I think logging full stack trace is good idea. Let's address in new Jira. +1, LGTM. ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-03-01 Thread kr-arjun
Github user kr-arjun commented on the issue: https://github.com/apache/drill/pull/1011 @paul-rogers Currently , the Client exception is being output as 'ClientContext.err.println(e.getMessage())' in DrillOnYarn.java. For most of application master launcher failures, only message

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-27 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 @arina-ielchiieva, do you want to give this one a committer +1? Then I'll mark it ready-to-commit. Thanks! ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-27 Thread Agirish
Github user Agirish commented on the issue: https://github.com/apache/drill/pull/1011 Looks good! +1. Getting this into AD 1.13.0 would be great for users. ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-27 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 Rebased onto latest master. ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-27 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 Fixed the drill-common dependency as @ilooner requested. ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-27 Thread Agirish
Github user Agirish commented on the issue: https://github.com/apache/drill/pull/1011 @arina-ielchiieva, sorry was held-up with something. I've just started on this - will get back shortly. ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-27 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1011 It would be good to add this feature in the upcoming 1.13.0 Drill release. To do so we need to ensure the following: @paul-rogers 1. Could you please fix failures on Travis? Tim

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-22 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1011 @paul-rogers You need to add this dependency to your drill-yarn pom.xml ``` org.apache.drill drill-common ${project.version} tests te

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-19 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 Failing in Travis, apparently due to test-framework issue: ``` Caused by: java.lang.ClassNotFoundException: org.apache.drill.categories.SecurityTest ``` @ilooner, any idea wh

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-19 Thread Agirish
Github user Agirish commented on the issue: https://github.com/apache/drill/pull/1011 @paul-rogers, I'll give it a try and update with my findings. ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-19 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 Rebased on latest master and resolved merge conflicts. Some ZK-related classes changed. Would be good if Abhishek could do a quick sanity test on his test cluster to make sure things stil

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-19 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1011 @paul-rogers based on @sachouche feedback could you please create Jira for enhancement and also resolve conflicts in bin.xml file? Thank you in advance! ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-05 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1011 +1 I have reviewed the code and overall looks good. My main feedback is that the current implementation doesn't currently support secure clusters (at least didn't see any logic associated with

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-05 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1011 @sachouche @vrozov @arina-ielchiieva please review ---