[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-28 Thread cchang738
Github user cchang738 commented on the issue: https://github.com/apache/drill/pull/1101 My test fail with OOM. @ilooner has test log. ---

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-28 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1101 Spoke with Chun, he will run the tests and update the PR with the test results. ---

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-22 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1101 @Ben-Zvi can you please do a final review? ---

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-15 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 @Ben-Zvi I applied your review comment, please let me know if you have any more comments. ---

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-08 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 @Ben-Zvi I have addressed review comments. All unit tests and functional tests (except for typical random failures are passing). I have included a commit for DRILL-6144 in this PR in order to fix

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-06 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 Travis failure is unrelated ---

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-06 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 @ppadma Responded to your comments. Please look at the last three commits for changes ---

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-02 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 An additional comment is that after the defaults were reduced the number of random failures we see in our functional tests decreased to just 3. Typically there are more than that. ---

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-02 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 @Ben-Zvi I have responded to comments and implemented requested changes. Please see latest commits for changes. I have made some additional changes after noticing that some of the batch sizing

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-01-26 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 @Ben-Zvi please review ---