Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1144
Looks good. +1
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1144
My two cents... DrillBuf is the only memory-level abstraction that (low
level) Drill code should reference. The UDLE and other bits should be fully
encapsulated. This guideline lets us evolve the
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1144
IMO, this PR or DRILL-6202 is not the best place to discuss boundary
checking as the PR and JIRA deals with `IndexOutOfBoundsException` but does not
change how DrillBuf, Vector or Operators ensure tha
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1144
I have added a comment within this PR associated JIRA:
[DRILL-6202](https://issues.apache.org/jira/browse/DRILL-6202)
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1144
I think we need to include a few other folks into this. @paul-rogers,
@sachouche, have also looked into the issue of excessive bounds checking and
ways to write to direct memory with minimum ove
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1144
It is not clear why get/set Byte/Char/Short/Int/Long/Float/Double do not
delegate to UDLE, while get/set Bytes delegates to UDLE and relies on netty
'AbstractByteBuf` for bounds checking. IMO, it will
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1144
To be honest, I don't know. There are too many paths available to write to
direct memory, some which were developed over time and so not all vector code
may be using them.
Ideally, every bit
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1144
Is there a reason to delegate `get/setBytes` to `AbstractByteBuf`? If not,
this PR will be a preparation step to use `PlatformDependent` directly
bypassing Netty bounds checking.
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1144
AFAIK, IndexOutOfBoundsException is thrown by Netty when a write to a
DrillBuf goes out of bounds (see
https://github.com/netty/netty/blob/netty-4.0.48.Final/buffer/src/main/java/io/netty/buffer
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1144
@parthchandra Please take a look.
---
10 matches
Mail list logo
