[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-23 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1160 +1, thanks for making the changes. ---

[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-23 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1160 During a freshly setup Drillbit: ![image](https://user-images.githubusercontent.com/4335237/37847547-644fa67c-2e8e-11e8-9aa7-2b4adf499cd0.png) While running 2 large (600M rows) join query

[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-23 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1160 +1 ---

[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-22 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1160 @arina-ielchiieva Restricting this PR to address the bug in `metrics.ftl` Will create a new PR for [DRILL-6289](https://issues.apache.org/jira/browse/DRILL-6289) ---

[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-12 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1160 I think I need to put up some tooltips. We're getting the metrics from the `drill.allocator.root.[peak|used]` values. I haven't seen a metric that shows the actual Direct allocation from the

[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-12 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1160 Looks wrong dunnit? Direct memory is (still?) showing as zero? ---

[GitHub] drill issue #1160: DRILL-6224: Publish current memory usage for Drillbits in...

2018-03-11 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1160 @parthchandra / @arina-ielchiieva would you guys want to review this? Here is a preview of how the details appear on the default page: ![image](https://user-images.githubusercontent.com/4335