Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
@arina-ielchiieva Should I do the commit or would you like to do that.
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
In that case, LGTM +1
Thank you for your work on this!. Are you going to take a look at the ESRI
format plugin?
---
Github user ChrisSandison commented on the issue:
https://github.com/apache/drill/pull/1201
@cgivre I had some issues between this and a previous branch I was working
on, but I fixed it by upgrade the base image that I was building it on. I ended
up building it on maven:3.5.3-jdk-8
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
LGTM +1
One thing, which I suspect may be a problem with my environment, not this
PR, but when I try to build the module with the tests, I get the following
errors:
```
[ERROR] F
Github user ChrisSandison commented on the issue:
https://github.com/apache/drill/pull/1201
@cgivre I'm also needing to use ST_DWithin
(https://postgis.net/docs/ST_DWithin.html). I'm going to add it to this PR.
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
@ChrisSandison Done. Here's a link to the JIRA
https://issues.apache.org/jira/browse/DRILL-6319
---
Github user ChrisSandison commented on the issue:
https://github.com/apache/drill/pull/1201
@cgivre I agree. Would you be able to open a JIRA ticket with any details
of the work that @k255 was doing for it?
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
If you want to include it on this PR that would be great, but Iâm fine
with including it in a separate PR as well. I want to get this functionality
into Drill asap, so it probably would be quicker
Github user ChrisSandison commented on the issue:
https://github.com/apache/drill/pull/1201
@cgivre do you mean including that in this PR?
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
@ChrisSandison This isn't a review comment, but @k255 was working on a
format plugin for ESRI shape files. Would you want to take a look and see if
we could get that in as well? I could see that bei
Github user ChrisSandison commented on the issue:
https://github.com/apache/drill/pull/1201
@cgivre added comments
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1201
@cgivre could you review this?
---
12 matches
Mail list logo
