Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
HI @brendanstennett I still am able to review if you'd like.
---
Github user brendanstennett commented on the issue:
https://github.com/apache/drill/pull/258
Hey guys, we have some cycles to have a look at this now. @ChrisSandison is
going to take a look who has made a few contributions to this project before.
---
Github user lherrmann974 commented on the issue:
https://github.com/apache/drill/pull/258
Pinging again.
If I may help, please let me know what I can do.
---
Github user brendanstennett commented on the issue:
https://github.com/apache/drill/pull/258
Hi @cgivre . I have some spare cycles coming up in our next open sprint
starting Apr 2 that either I or someone on my team can take a look at it to get
it across if it isn't already. Will ke
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
Hi Brendan, I can review it if you can complete it.
âC
> On Mar 6, 2018, at 10:57, Brendan Stennett
wrote:
>
> +1 And would be happy to help get it across the finish line
Github user brendanstennett commented on the issue:
https://github.com/apache/drill/pull/258
+1 And would be happy to help get it across the finish line for you.
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
I also would really like to see this through to completion. If there is
something I can do, please let me know.
> On Mar 6, 2018, at 08:04, lherrmann974 wrote:
>
> Hello,
> any n
Github user lherrmann974 commented on the issue:
https://github.com/apache/drill/pull/258
Hello,
any news on this PR ? The upgraded GIS abilities would be greatly
appreciated.
Thanks in advance.
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
I'm getting some unit test failures when I build this.
[org.apache.drill.exec.expr.fn.impl.gis.TestGeometryFunctions.txt](https://github.com/apache/drill/files/1483754/org.apache.drill.exec.expr.f
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/258
@cgivre regarding the commit process, you can send me a note at
amansi...@apache.org and I can walk through it. Although someone else
familiar with the process could do the commit, it would be
Github user k255 commented on the issue:
https://github.com/apache/drill/pull/258
It's good that now there's commiter which is aware of the GIS context! The
list of functions added in this PR is as follows:
ST_Buffer, ST_Contains, ST_Crosses, ST_Difference, ST_Disjoint,
ST_DiST_an
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
Hi there,
This will be my first commit, (AH!) so any assistance would be greatly
appreciated. I would like to see some documentation, or at minimum a list of
what functions are included and sente
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/258
Thanks @k255 . @cgivre once you have reviewed and are satisfied, pls mark
the JIRA as ready-to-commit label. Also, what do you both think about
documentation for these GIS functions ?
---
Github user k255 commented on the issue:
https://github.com/apache/drill/pull/258
@amansinha100 better later than never! The PR is updated now.
@cgivre offered that he could help reviewing this.
@joeauty probably in further development we can consider adding geojson
support. I'
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/258
Somehow these extensions to the GIS module never got reviewed ! (the
original GIS functions are in the contrib). @k255 would you be able to rebase
your PR onto the latest master branch ? Hopefu
Github user joeauty commented on the issue:
https://github.com/apache/drill/pull/258
I'm super excited about this! Just wondering, is there plans for
ST_ASGeoJSON?
---
16 matches
Mail list logo
