[GitHub] drill issue #521: DRILL-4715: Fix java compilation error in run-time generat...

2016-06-14 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/521 @jacques-n @amansinha100 , can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill issue #521: DRILL-4715: Fix java compilation error in run-time generat...

2016-06-16 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/521 I had couple of minor comments. Changes LGTM. +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] drill issue #521: DRILL-4715: Fix java compilation error in run-time generat...

2016-06-16 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/521 Just to be sure, I confirmed with @jinfengni that the new generated code would look like the following: (assume 100 expressions in the Project and limit of 50 exprs per block): doEval() {

[GitHub] drill issue #521: DRILL-4715: Fix java compilation error in run-time generat...

2016-06-23 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/521 @sudheeshkatkam , do you want to take a quick look and see if I have addressed your comments? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear o