Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/600
+1. Yes this is fine, and the tests all pass as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/600
@parthchandra The known issue with hive that it stores timestamp values
into parquet files with local zone retain. That's why when we want to retrieve
the data from such table we should consider the
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/600
@vdiravka Looks like the test
TestHiveStorage.readAllSupportedHiveDataTypesNativeParquet:214 is also failing.
(The timestamp_field value is not matching the baseline). Can you take a look?
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/600
Changing this to -1 until unit test failure is addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/600
+1. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/600
@bitblender @parthchandra
Changes according to the comments were made, the branch version was rebased
to the master version.
Could you please review?
---
If your project is set up for it,
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/600
@bitblender Sorry about this. That was hidden `\u` symbols.
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user bitblender commented on the issue:
https://github.com/apache/drill/pull/600
I can't see NullableFixedByteAlignedReaders.java. Shows up as a binary file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
