[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2017-03-01 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/613 yes, pull requests have been kept in sync. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2017-02-28 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/613 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2017-02-06 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/613 @sudheeshkatkam can you please give it another review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2016-11-04 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/613 I added the necessary fallbacks for prepared statement and metadata, so a new client should now be able to talk with an old server without adverse effects. I would prefer that this change t

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2016-11-04 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/613 I just realized you mentioned about this on the mailing list. In that case, let's defer committing this pull request to the next release. > That said, the metadata change is not merged

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2016-11-04 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/613 @laurentgo thanks for splitting the commit! Looks like queries are replaced by API calls in the core changes, so can the new driver talk to old servers? --- If your project is set up

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2016-11-02 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/613 the only "refactoring" I can think of is between DrillCursor and DrillResultSetImpl, anything else is related to the feature. I'll try to split it, but hopefully in the current state, it should stil

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/613 I started looking into this. Can you please split the commit into two (refactoring changes, and the core changes that use new API) for quicker review? --- If your project is set up for it, you