Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/652
I did not add new unit tests because existing tests already provide enough
coverage and they run on local file system.
---
If your project is set up for it, you can reply to this email and have your
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/652
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/652
This pull request was never merged because of a problem with windows test
setup we have. As a workaround, I added code to fall back to using old API if
new API fails for some reason. All tests are pas
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/652
@sohami Sorabh, since you reviewed the original pull request, can you
please review the updated diffs ?
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/652
Based on the last in-person discussion it was decided to further look into
why the test was failing on Windows platform. Is it the test environment setup
issue or an actual issue w.r.t platform impleme
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/652
@ppadma can you rebase this with the current master, and include the
workaround? It does not make sense to hold up this commit for so long if a
workaround for the Windows platform is sufficient.
---
