Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/660
+1
LGTM. Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/660
Rebased on master as master had drifted along in the three weeks this PR
has been active.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/660
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/660
Paul, it's really good feature! I have left some comments in PR.
Other than that:
1. Please format the code to remove unnecessary spaces.
Examples:
addClass( key, results.get( k
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/660
Revised title to include correct JIRA title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
