[GitHub] drill issue #755: DRILL-5270: Improve loading of profiles listing in the Web...

2018-03-14 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/755 Holding off to do a rebase once @vrozov 's PR #1163 (DRILL-6053) goes into Apache. ---

[GitHub] drill issue #755: DRILL-5270: Improve loading of profiles listing in the Web...

2018-03-02 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/755 Thanks, @vrozov. I'll make use of a separate lock for read-only purpose in case of `#1`. For `#2`, I need to construct a size-limited ordered set from a list of unordered elements. In this

[GitHub] drill issue #755: DRILL-5270: Improve loading of profiles listing in the Web...

2018-03-02 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/755 @kkhatua 1. The read locks are not exclusive (single writer/multiple readers). To achieve the required functionality you need to introduce a different lock and use write (or exclusive) lock.

[GitHub] drill issue #755: DRILL-5270: Improve loading of profiles listing in the Web...

2018-03-02 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/755 The choice for a `TreeSet` is to basically use a binary structure that keeps the (maximum permitted) profiles sorted and in memory. When Drill detect changes, (Refer

[GitHub] drill issue #755: DRILL-5270: Improve loading of profiles listing in the Web...

2018-03-02 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/755 @arina-ielchiieva I need to rebase this on top of the latest master considering it was originally based on nearly a year old code. When ready, i'll create a new PR or push to this one. Let me know

[GitHub] drill issue #755: DRILL-5270: Improve loading of profiles listing in the Web...

2017-04-21 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/755 @sudheeshkatkam Can you please review the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill issue #755: DRILL-5270: Improve loading of profiles listing in the Web...

2017-02-21 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/755 For 8266 profiles, when measured from Chrome browser's Network tool: ``` Load First Time: 2.43s Load Second Time (no new profiles): 829ms ``` --- If your project is set up for it,

[GitHub] drill issue #755: DRILL-5270: Improve loading of profiles listing in the Web...

2017-02-21 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/755 A summary of the performance is available in this