Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/846
Commits are squashed into one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/846
Given that the page sizes are small (~ 1MB), then the solution simply
transfers a modest amount of memory from heap to direct. So, LGTM.
+1
---
If your project is set up for it, you can
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/846
@paul-rogers As I mentioned in my previous comment the page size can't
greatly exceed 1Mb (default value of page-size option in Drill). And I checked
it -- almost every time the page size is much les
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/846
Chatted with Parth who mentioned that Parquet page sizes are typically on
the order of 1MB, maybe 8 MB, but 16 MB is too large.
The concern expressed in earlier comments was that if we buf
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/846
Another critical issue here. Direct memory is not a limitless resource,
unfortunately. Allocating memory larger than 16 MB causes memory fragmentation
as the allocation must come from the system,
