Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/891
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/891
@parthchandra could you please do final review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user sindhurirayavaram commented on the issue:
https://github.com/apache/drill/pull/891
@arina-ielchiieva After the first commit, I had a detailed discussion with
@parthchandra. There are two reasons two include all the js and css files
locally
1) The biggest library among
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/891
@sindhurirayavaram I am a little confused with your latest changes. I
thought the main purpose of this PR is not to include js and css files into
Drill code as was discussed in https://github
Github user sindhurirayavaram commented on the issue:
https://github.com/apache/drill/pull/891
@arina! I am planning to keep all the files in the local resources file! I
have mentioned the reasons above. Yes, onload should be used for IE.
---
If your project is set up for it, you can
Github user sindhurirayavaram commented on the issue:
https://github.com/apache/drill/pull/891
We are trying to load jquery, datatables libraries here. The jquery library
is already available in the resources which generic page is using. We are
including generic in the result page. So
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/891
@sindhurirayavaram, one more question about browser compatibility:
will this work in Chrome, Mozilla, Safari etc?
For example, quick search shows that there are can be issues with diffe
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/891
Regarding build failure, it will fail only if we did not download these
files before. If we did, it will take them from the cache:
`[INFO] --- download-maven-plugin:1.3.0:wget
(add-datata
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/891
Actually you are right, there are benefits of using CDN first [1].
[1]
https://stackoverflow.com/questions/1014203/best-way-to-use-googles-hosted-jquery-but-fall-back-to-my-hosted-lib
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/891
> Even if we have local files it's better to check the browser's cache
first. If that fails, we can load them locally.
But why? javascript and css files have stable versions. If we downloa
Github user sindhurirayavaram commented on the issue:
https://github.com/apache/drill/pull/891
@arina-ielchiieva Thanks for the comments! Yes drillbit fails if it can't
download them during build time. These are pretty large fails. Is it good to
add them in the source tree?
To an
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/891
I have checked and build will fail: `Failed to execute goal
com.googlecode.maven-download-plugin:download-maven-plugin:1.3.0:wget
(add-jquery-as-resource) on project drill-java-exec: IO Error
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/891
@sindhurirayavaram, thanks for the PR! I have two questions though:
1. Will Drill build fail if we could not download these the javascript and
css files during build time?
2. If the an
13 matches
Mail list logo
