Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/905
Since Drill does not have enough information about tables in the planning
time to avoid this OOM and since without using the `getMaxRowCount()` for
`ScanPrel`, current approach could not be used
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/905
@jinfengni it was an inflated example, but considering the case of multiple
joins and when tables have several repeated values, the result will be the
same.
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/905
@amansinha100, can you give this one a review?
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/905
@jinfengni, the idea is very interesting for me. More appropriate memory
cost estimation will cause to choosing better plans, that will cause the less
time execution and memory costs.
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/905
@vvysotskyi , what I'm thinking is not just comparing the ratio of column
count vs ratio of row count.
Let's take a step back. This SwapHashJoinVisitor is trying to correct the
join
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/905
@jinfengni thanks for looking into this. Completely agree with you that it
would be better to consider both row and column count.
Unfortunately, it does not help to fix this issue, since the
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/905
This OOM problem exposes two problems. The first one is in planning time,
where we choose a sub-optimal plan, due to the inaccurate estimation of row
count because of missing of appropriate
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/905
@jinfengni, have you been able to take a look at this PR?
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/905
@jinfengni, I think you are more familiar with this part of the code, can
you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/905
@paul-rogers @jinfengni can you please review this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
10 matches
Mail list logo
