Github user sohami commented on the issue:
https://github.com/apache/drill/pull/919
Rebased on latest master and squashed the initial 3 commits. But I have
kept the commit to resolve conflict separate as there are some changes made
w.r.t DRILL-3449 behavior, and added some new unit te
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/919
Attempt to merge into master failed:
```
CONFLICT (content): Merge conflict in
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentStatusReporter.java
```
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/919
I rebased this PR to latest master and [re-ran functional
test](http://10.10.104.91:8080/job/Functional/2447/console) and seeing only 2
random failures now. As per @agirish recommendation I have create
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/919
@paul-rogers - Last week @amansinha100 also reported 5 Random failures
happening with this commit. But when ran in isolation for multiple iterations
those tests were passing all the time. Can you plea
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/919
Tried to commit this one to master. The functional test run failed with 20+
"random failures." That is too many to comfortably allow. So, @sohami, please
rerun this, determine if the 20+ failures
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/919
OK, thanks. Got confused by the commit messages that appeared after the +1.
Maybe in the future, when we rebase, just add a comment saying that's what
happened.
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/919
@paul-rogers - Not sure which commit you are referring to. All the commits
are reviewed by @parthchandra. I just rebased commits to latest master after
last week pull request since @amansinha100 was ob
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/919
@sohami, can you clean up the stray commits and ask @parthchandra to again
review the later commits?
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/919
@parthchandra - thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/919
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/919
Rebased the branch to latest master and updated test's included in
DRILL-5701
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/919
@parthchandra - Please help to review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
12 matches
Mail list logo
