Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/950
Go for it. I won't do any more commits until you give the all-clear.
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/950
Rebased again. Also updated protobuf files.
If there are no further comments, I'll be merging this PR in.
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/950
Squashed and rebased on master again.
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/950
@laurentgo are you good with this? I'll open a new JIRA for the
enhancements to the C++ client.
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/950
@arina-ielchiieva The `TestSSLConfig.testMissingKeystorePassword` test
will fail if the exception is not thrown. The test is checking that the
exception is in fact being thrown. Anyway, I added
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/950
Squashed the review changes and rebased on master.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/950
@parthchandra could you please resolve the conflicts?
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/950
Thanks for the changes!
+1 LGTM.
---
