Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/169#issuecomment-143380757
+1 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40484865
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitUnionExchangeTransposeRule.java
---
@@ -0,0 +1,64 @@
+/**
+ * Lic
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/169#issuecomment-143375295
Revise the code based on comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40484523
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
---
@@ -26,4 +30,34 @@
public void testL
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40484512
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
---
@@ -26,4 +30,34 @@
public void testL
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40484389
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLimitRelBase.java
---
@@ -36,11 +36,17 @@
public abstract class DrillL
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40469361
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitUnionExchangeTransposeRule.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licen
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40465777
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitUnionExchangeTransposeRule.java
---
@@ -0,0 +1,64 @@
+/**
+ * Li
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40449942
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitUnionExchangeTransposeRule.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licen
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40447157
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitUnionExchangeTransposeRule.java
---
@@ -0,0 +1,64 @@
+/**
+ * Li
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40446899
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLimitRelBase.java
---
@@ -36,11 +36,17 @@
public abstract class Drill
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40445053
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
---
@@ -26,4 +30,34 @@
public void te
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40444952
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
---
@@ -26,4 +30,34 @@
public void te
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40444664
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitUnionExchangeTransposeRule.java
---
@@ -0,0 +1,64 @@
+/**
+ *
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40444588
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLimitRelBase.java
---
@@ -36,11 +36,17 @@
public abstract class Dri
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/169
DRILL-1457: Push Limit past through UnionExchange.
Aman, could you please review this pull request?
You can merge this pull request into a Git repository by running:
$ git pull https://github
17 matches
Mail list logo