GitHub user parthchandra opened a pull request:
https://github.com/apache/drill/pull/219
DRILL-3871: Off by one error while reading binary fields with one terâ¦
â¦minal null in parquet.
Changes -
1) Rewrote the NullableColumnReader.processPages function to process ru
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/219#discussion_r43432757
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableColumnReader.java
---
@@ -29,117 +29,152 @@
import parq
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/219#discussion_r43440673
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableColumnReader.java
---
@@ -29,117 +29,152 @@
import
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/219#discussion_r43446889
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableColumnReader.java
---
@@ -29,117 +29,152 @@
import parq
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/219#discussion_r43447604
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableColumnReader.java
---
@@ -29,117 +29,152 @@
import
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/219#issuecomment-152344086
+1, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/219#issuecomment-152588218
+1, thanks for cleaning this up Parth!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/219
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
