[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

2015-11-02 Thread mehant
GitHub user mehant opened a pull request: https://github.com/apache/drill/pull/230 DRILL-3941: Add timing instrumentation in different phases of partiti… …on pruning Add basic timing instrumentation while initializing FileSelection and reading the metadata cache file Y

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

2015-11-02 Thread mehant
Github user mehant commented on the pull request: https://github.com/apache/drill/pull/230#issuecomment-153201984 @amansinha100 can you please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

2015-11-02 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/230#discussion_r43706195 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -163,7 +163,9 @@ private ParquetTableMetadata_v1 getParq

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

2015-11-02 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/230#discussion_r43706257 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java --- @@ -166,16 +174,28 @@ protected void doOnMa

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

2015-11-02 Thread mehant
Github user mehant commented on a diff in the pull request: https://github.com/apache/drill/pull/230#discussion_r43706628 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -163,7 +163,9 @@ private ParquetTableMetadata_v1 getParquetTab

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

2015-11-02 Thread mehant
Github user mehant commented on a diff in the pull request: https://github.com/apache/drill/pull/230#discussion_r43706882 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java --- @@ -166,16 +174,28 @@ protected void doOnMatch(Re

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

2015-11-04 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/230#issuecomment-153780284 +1. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

2015-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl