Github user hsuanyi closed the pull request at:
https://github.com/apache/drill/pull/242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/233
DRILL-4006: Ensure the position of MapWriters is set
This can help eliminate potential IOOB exception
You can merge this pull request into a Git repository by running:
$ git pull https://github.
Github user zfong commented on the pull request:
https://github.com/apache/drill/pull/233#issuecomment-153421208
Is it possible to add a unit test for this problem? Seems like a pretty
straightforward repro. Thanks.
---
If your project is set up for it, you can reply to this email
Github user hsuanyi closed the pull request at:
https://github.com/apache/drill/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/233#issuecomment-153421763
Will do after I rebase it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/233#discussion_r43777175
--- Diff: exec/java-exec/src/main/codegen/templates/MapWriters.java ---
@@ -110,9 +110,9 @@ public ListWriter list(String name) {
FieldWriter writer
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/242
DRILL-4006: Ensure the position of MapWriters is set
This can help eliminate potential IOOB exception
You can merge this pull request into a Git repository by running:
$ git pull https://github.
Github user StevenMPhillips commented on the pull request:
https://github.com/apache/drill/pull/242#issuecomment-153924675
I think the fix is in the wrong place. We should fix the underlying vector.
I was able to fix the problem with a small change to
BaseRepeatedValueVector.BaseRepea
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/242#issuecomment-153926043
You mean the DRILL-4032?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user StevenMPhillips commented on the pull request:
https://github.com/apache/drill/pull/242#issuecomment-153933449
No, I'm talking about this issue. The problem is not really with the
writer, its in the underlying vector.
---
If your project is set up for it, you can reply to
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/242#issuecomment-153949709
Do you like to fix this issue or you like me to update my patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
11 matches
Mail list logo