[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...

2015-12-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/281 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...

2015-11-30 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/281#issuecomment-160799401 I put it on my merge branch but it actually caused two small compilation issues in other modules that were using the utility method you refactored. I forgot to update

[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...

2015-11-30 Thread julienledem
Github user julienledem commented on the pull request: https://github.com/apache/drill/pull/281#issuecomment-160790637 Thanks @jaltekruse ! Did you mean to commit this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...

2015-11-30 Thread julienledem
Github user julienledem commented on the pull request: https://github.com/apache/drill/pull/281#issuecomment-160803787 Thanks for the heads up. I will fix this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...

2015-11-25 Thread jaltekruse
Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/281#issuecomment-159748623 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4124: Make all uses of AutoCloseables us...

2015-11-23 Thread julienledem
GitHub user julienledem opened a pull request: https://github.com/apache/drill/pull/281 DRILL-4124: Make all uses of AutoCloseables use addSuppressed exceptions to avoid noise in logs You can merge this pull request into a Git repository by running: $ git pull