GitHub user jacques-n opened a pull request:
https://github.com/apache/drill/pull/327
DRILL-4131: Move RPC allocators under Drill's root allocator & accounting
- Allow settings to be set to ensure RPC reservation and maximums
(currently unset by default). Defaults set in drill-modul
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/327#discussion_r50024752
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -56,22 +60,83 @@
private final DrillConfig config;
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/327#discussion_r50026812
--- Diff:
exec/memory/base/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java ---
@@ -59,7 +59,7 @@ public PooledByteBufAllocatorL(MetricRegistry regi
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/327#issuecomment-172604924
apart from a small code change, LGTM.
Let's run a couple of tests (performance and concurrency) before merging
this PR.
+1
---
If your project is set up f
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/327#discussion_r50033210
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -56,22 +60,83 @@
private final DrillConfig config;
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/327#discussion_r50033277
--- Diff:
exec/memory/base/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java ---
@@ -59,7 +59,7 @@ public PooledByteBufAllocatorL(MetricRegistry reg
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/327#issuecomment-172623959
One quick note, I still am receiving failures on a small set of unit tests
because of metric registration conflicts so I'll be fixing those. (Happens only
in tests wher
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/327#discussion_r50167961
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -56,22 +60,83 @@
private final DrillConfig config
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/327#discussion_r50182483
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -56,22 +60,83 @@
private final DrillConfig config;
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
10 matches
Mail list logo
