[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-02-10 Thread hnfgns
Github user hnfgns closed the pull request at: https://github.com/apache/drill/pull/325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-22 Thread hnfgns
Github user hnfgns commented on the pull request: https://github.com/apache/drill/pull/325#issuecomment-174113221 I have created the following [doodle](http://doodle.com/poll/zxkxdzfkgfuanw59) to schedule this. --- If your project is set up for it, you can reply to this email and

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-19 Thread hnfgns
Github user hnfgns commented on the pull request: https://github.com/apache/drill/pull/325#issuecomment-173003718 How about anytime tomorrow from 10am till noon? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-18 Thread hnfgns
Github user hnfgns commented on the pull request: https://github.com/apache/drill/pull/325#issuecomment-172604790 Cool. Let's sync up on tomorrow's weekly hangout. Let me know if that does not work for you. --- If your project is set up for it, you can reply to this email and have

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-18 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/325#issuecomment-172747355 Let's do a separate hangout. This seems to deep/specific to cover in a large group. On Jan 18, 2016 9:51 AM, "Hanifi Gunes" wrote:

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-17 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/325#issuecomment-172369155 You want to do a hangout to discuss the concept of EStores and watches and the relationship with the ClusterCoordinator interface. We're currently actively in the

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-15 Thread hnfgns
GitHub user hnfgns opened a pull request: https://github.com/apache/drill/pull/325 DRILL-4275: Refactor e/pstore interfaces and their factories to provide a unified mechanism to access stores The main changes are the following: Remove EStore and EStoreProvider interfaces.

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-15 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/325#discussion_r49909762 --- Diff: contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java --- @@ -180,39 +179,39 @@ private void init() throws

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-15 Thread hnfgns
Github user hnfgns commented on a diff in the pull request: https://github.com/apache/drill/pull/325#discussion_r49916936 --- Diff: contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java --- @@ -180,39 +179,39 @@ private void init() throws

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-15 Thread hnfgns
Github user hnfgns commented on the pull request: https://github.com/apache/drill/pull/325#issuecomment-172126518 I took the API somewhat Drill internal but you are right about discussing this in the public list first. This patch -as the numbers above check out- is more of a clean-up