[GitHub] drill pull request: DRILL-4531: Add a Drill customized rule for pu...

2016-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-4531: Add a Drill customized rule for pu...

2016-03-25 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/444#issuecomment-201505793 Yeah, you're right and thanks for reviewing fully. We can shelve for now but this definitely seems like something we should get to. +1 on the patch. --- If

[GitHub] drill pull request: DRILL-4531: Add a Drill customized rule for pu...

2016-03-25 Thread jinfengni
Github user jinfengni commented on the pull request: https://github.com/apache/drill/pull/444#issuecomment-201430413 I agree that your expectation for RelSubset makes sense to me. However, for now it does not happen that way. The following is the trace for the query which went

[GitHub] drill pull request: DRILL-4531: Add a Drill customized rule for pu...

2016-03-24 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/444#discussion_r57384554 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillFilterAggregateTransposeRule.java --- @@ -0,0 +1,28 @@ +/** + *

[GitHub] drill pull request: DRILL-4531: Add a Drill customized rule for pu...

2016-03-24 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/444#discussion_r57380087 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillFilterAggregateTransposeRule.java --- @@ -0,0 +1,28 @@ +/** +

[GitHub] drill pull request: DRILL-4531: Add a Drill customized rule for pu...

2016-03-24 Thread jinfengni
GitHub user jinfengni opened a pull request: https://github.com/apache/drill/pull/444 DRILL-4531: Add a Drill customized rule for pushing filter past aggre… …gate You can merge this pull request into a Git repository by running: $ git pull