Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/468
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/468#issuecomment-207904379
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/468#issuecomment-207132298
LGTM. +1. Since this fix is not directly changing the cost of per-row
filter evaluation itself (it is reducing the number of rows on which filter
evaluation is
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/468#issuecomment-207115616
@amansinha100 and @hsuanyi , I revised PR based on your comments. Can you
take another look? thx.
---
If your project is set up for it, you can reply to this
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58953148
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58949303
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58926583
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58921685
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
@@ -148,13 +139,41 @@ public String
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58921279
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58912269
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58911205
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
@@ -148,13 +139,41 @@ public String getName(int
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58824977
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58824883
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
@@ -148,13 +139,41 @@ public String getName(int
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/468#issuecomment-206611168
@amansinha100 , could you please review this PR? thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/468
DRILL-4589: Reduce planning time for file system partition pruning byâ¦
⦠reducing filter evaluation overhead
You can merge this pull request into a Git repository by running:
$ git pull
15 matches
Mail list logo
