[GitHub] drill pull request: DRILL-4679: When convert() functions are prese...

2016-05-20 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/504#issuecomment-220730151 Committed in 3d92d2829. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] drill pull request: DRILL-4679: When convert() functions are prese...

2016-05-20 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/504#discussion_r64091394 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java --- @@ -146,6 +159,27 @@ protected

[GitHub] drill pull request: DRILL-4679: When convert() functions are prese...

2016-05-20 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/504#discussion_r64064412 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java --- @@ -136,6 +145,10 @@ public VectorContainer

[GitHub] drill pull request: DRILL-4679: When convert() functions are prese...

2016-05-20 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/504#discussion_r64063077 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java --- @@ -146,6 +159,27 @@ protected IterOutcome

[GitHub] drill pull request: DRILL-4679: When convert() functions are prese...

2016-05-20 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/504#issuecomment-220525522 @jinfengni could you pls review ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] drill pull request: DRILL-4679: When convert() functions are prese...

2016-05-19 Thread amansinha100
GitHub user amansinha100 opened a pull request: https://github.com/apache/drill/pull/504 DRILL-4679: When convert() functions are present, ensure that Project… …RecordBatch produces a schema even for empty result set. Add unit tests You can merge this pull request into