Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/429#issuecomment-210564638
There are two independent changes in this patch. So I moved the DrillClient
changes to #480
---
If your project is set up for it, you can reply to this email and
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r57475224
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
---
@@ -50,8 +52,12 @@
public BootStrapContext(DrillConfig
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r57470730
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
---
@@ -50,8 +52,12 @@
public BootStrapContext(DrillCo
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/429#issuecomment-201357479
The package info looks good and is a nice addition. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r57460954
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
---
@@ -50,8 +52,12 @@
public BootStrapContext(DrillConfig
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/429#issuecomment-201191189
Please re-review as I have more changes; I hope splitting up the changes
into 4 commits helps.
@jacques-n can you also review rpc.control package info?
-
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r57426117
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -74,73 +74,148 @@
/**
* Thin wrapper around a Use
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r57426103
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -74,73 +74,148 @@
/**
* Thin wrapper around a Use
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r57426098
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/client/DrillClientSystemTest.java
---
@@ -51,7 +51,7 @@ public void tearDownTest() {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r57426094
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
---
@@ -50,8 +52,12 @@
public BootStrapContext(DrillCo
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r56082440
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -74,73 +74,148 @@
/**
* Thin wrapper around a UserClie
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r56080621
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -74,73 +74,148 @@
/**
* Thin wrapper around a Use
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r56060382
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -74,73 +74,148 @@
/**
* Thin wrapper around a UserClient
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r56058208
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -74,73 +74,148 @@
/**
* Thin wrapper around a UserClient
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r55952628
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/client/DrillClientSystemTest.java
---
@@ -51,7 +51,7 @@ public void tearDownTest() {
@Te
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r55952611
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
---
@@ -50,8 +52,12 @@
public BootStrapContext(DrillConfig
GitHub user sudheeshkatkam opened a pull request:
https://github.com/apache/drill/pull/429
Drill 4504: Create an event loop for each of [user, control, data] RPC
components
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sudhees
17 matches
Mail list logo