Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r35048317
--- Diff:
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java
---
@@ -27,11 +27,20 @@
static final org.slf4j.Logger logg
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r35042822
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -138,34 +155,77 @@ public static DrillConfig create(Properties
testCon
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r35042277
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -138,34 +154,83 @@ public static DrillConfig create(Properties
testCon
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r35041506
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -115,19 +124,26 @@ public static DrillConfig forClient() {
*
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r35032132
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -90,7 +97,8 @@ public DrillConfig(Config config, boolean enableServer)
To make the topic even that much more annoying to discuss, a static final
variable in java is typically noted in all UPPER CASE...
I would vote for this notation and any of the following would be my
personal preference, but I am not a committer... s
private static final Logger logger = Log
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r35031778
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -44,31 +46,37 @@
import com.google.common.collect.ImmutableList;
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r35031355
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -44,26 +46,33 @@
import com.google.common.collect.ImmutableList;
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/93#issuecomment-121695453
Since "user action" affects the messages, I'd say INFO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r34708277
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -138,34 +154,76 @@ public static DrillConfig create(Properties
tes
Github user dsbos commented on the pull request:
https://github.com/apache/drill/pull/93#issuecomment-121513460
> ... clutter Lilith ... 3) Every other log statement in your patch should
be TRACE level. ...
Commit 872309a... reverts to one log call and log entry per list, but
Github user dsbos commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r34650500
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -138,34 +155,77 @@ public static DrillConfig create(Properties
testConfigur
Github user dsbos commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r34649690
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -138,34 +155,77 @@ public static DrillConfig create(Properties
testConfigur
Github user dsbos commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r34642779
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -44,26 +46,33 @@
import com.google.common.collect.ImmutableList;
i
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/93#issuecomment-121452663
It seems we will be logging too much at DEBUG level (mainly through
LogicalOperatorBase and PhysicalOperatorUtil); it will clutter Lilith
specially.
IMO,
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r34639451
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -138,34 +155,77 @@ public static DrillConfig create(Properties
tes
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/93#issuecomment-121437274
DRILL-2815, DRILL-3496 Adding a link to the related JIRA reports
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r34634944
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -138,34 +155,77 @@ public static DrillConfig create(Properties
tes
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r34634834
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -44,26 +46,33 @@
import com.google.common.collect.ImmutableLis
GitHub user dsbos opened a pull request:
https://github.com/apache/drill/pull/93
Enhanced logging and associated code hygiene
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsbos/incubator-drill
bugs/drill-2815-etc-Logging
Alt
20 matches
Mail list logo
