[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1138 ---

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172618093 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/ExtendableRelDataTypeHolder.java --- @@ -0,0 +1,82 @@ +/* + *

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172630422 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -277,6 +279,25 @@ public String deriveAlias(

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172620291 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroDrillTable.java --- @@ -58,16 +65,31 @@ public AvroDrillTable(String

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172618262 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java --- @@ -78,6 +79,23 @@ public ColumnExplorer(OptionManager

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172600066 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroDrillTable.java --- @@ -58,16 +65,31 @@ public AvroDrillTable(String

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172606583 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -277,6 +279,25 @@ public String deriveAlias(

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172599233 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java --- @@ -78,6 +79,23 @@ public ColumnExplorer(OptionManager

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r172606895 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/ExtendableRelDataTypeHolder.java --- @@ -0,0 +1,82 @@ +/* + *

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r171606330 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java --- @@ -154,6 +156,12 @@ public int next() {

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-01 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r171607241 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java --- @@ -295,7 +301,8 @@ private void

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-01 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r171544478 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/avro/AvroFormatTest.java --- @@ -170,25 +169,35 @@ public void

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-03-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1138#discussion_r171517376 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/avro/AvroFormatTest.java --- @@ -170,25 +169,35 @@ public void

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

2018-02-28 Thread vvysotskyi
GitHub user vvysotskyi opened a pull request: https://github.com/apache/drill/pull/1138 DRILL-4120: Allow implicit columns for Avro storage format Existing implementation of `AvroDrillTabl` does not allow dynamic columns discovering. `AvroDrillTable.getRowType()` method returns