[GitHub] drill pull request #1236: DRILL-6347: Inconsistent method name "field".

2018-04-23 Thread HanumathRao
Github user HanumathRao commented on a diff in the pull request: https://github.com/apache/drill/pull/1236#discussion_r183384261 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java --- @@ -88,10 +88,10 @@ public void end

[GitHub] drill pull request #1236: DRILL-6347: Inconsistent method name "field".

2018-04-23 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1236#discussion_r183341109 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java --- @@ -88,10 +88,10 @@ public voi

[GitHub] drill pull request #1236: DRILL-6347: Inconsistent method name "field".

2018-04-21 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/drill/pull/1236 DRILL-6347: Inconsistent method name "field". The method is names as "field", but the method is mainly doing appending. So that, rename the method as "append" should be better. You can merge th