[GitHub] drill pull request #1242: DRILL-6361: Revised typeOf() function versions

2018-05-02 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1242#discussion_r185464800 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctionHelpers.java --- @@ -202,6 +204,127 @@ public static String toStr

[GitHub] drill pull request #1242: DRILL-6361: Revised typeOf() function versions

2018-05-02 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1242#discussion_r185458392 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestTypeFns.java --- @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache S

[GitHub] drill pull request #1242: DRILL-6361: Revised typeOf() function versions

2018-05-02 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1242#discussion_r185435469 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/UnionFunctions.java --- @@ -146,16 +139,131 @@ private static int getTypeValue(

[GitHub] drill pull request #1242: DRILL-6361: Revised typeOf() function versions

2018-04-28 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/1242 DRILL-6361: Revised typeOf() function versions Drill provides the `typeof()` function to return the type of a column. However, this function has two key limitations: 1. It returns NULL