[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

2018-04-02 Thread ChrisSandison
Github user ChrisSandison commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r178652351 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STUnionAggregate.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to the

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

2018-04-02 Thread ChrisSandison
Github user ChrisSandison commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r178619522 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STXFunc.java --- @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache So

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

2017-11-02 Thread cgivre
Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148653960 --- Diff: contrib/gis/src/test/java/org/apache/drill/exec/expr/fn/impl/gis/TestGeometryFunctions.java --- @@ -72,4 +72,203 @@ public void testSTWithinQuery()

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

2017-10-31 Thread cgivre
Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148117858 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STContains.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Softwa

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

2017-10-31 Thread cgivre
Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148114646 --- Diff: contrib/gis/src/main/java/com/esri/core/geometry/VertexGeomAccessor.java --- @@ -0,0 +1,25 @@ +/** --- End diff -- Please put the Ap

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

2017-10-31 Thread cgivre
Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148172580 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STUnionAggregate.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

2017-10-31 Thread cgivre
Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148172786 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STUnionAggregate.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

2017-10-31 Thread cgivre
Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148115797 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STBuffer.java --- @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software