[GitHub] drill pull request #512: Drill 4573 fix issue with unicode chars

2016-06-13 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/512#discussion_r66894981 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java --- @@ -114,6 +114,19 @@ public void testRegexpMatches()

[GitHub] drill pull request #512: Drill 4573 fix issue with unicode chars

2016-06-13 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/512#discussion_r66894665 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSequenceWrapper.java --- @@ -17,13 +17,52 @@ */ package

[GitHub] drill pull request #512: Drill 4573 fix issue with unicode chars

2016-06-08 Thread jcmcote
Github user jcmcote commented on a diff in the pull request: https://github.com/apache/drill/pull/512#discussion_r66374867 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java --- @@ -114,6 +114,19 @@ public void testRegexpMatches()

[GitHub] drill pull request #512: Drill 4573 fix issue with unicode chars

2016-06-08 Thread jcmcote
Github user jcmcote commented on a diff in the pull request: https://github.com/apache/drill/pull/512#discussion_r66370984 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSequenceWrapper.java --- @@ -17,13 +17,52 @@ */ package

[GitHub] drill pull request #512: Drill 4573 fix issue with unicode chars

2016-06-08 Thread jcmcote
Github user jcmcote commented on a diff in the pull request: https://github.com/apache/drill/pull/512#discussion_r66370159 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java --- @@ -114,6 +114,19 @@ public void testRegexpMatches()

[GitHub] drill pull request #512: Drill 4573 fix issue with unicode chars

2016-06-06 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/512#discussion_r65994802 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java --- @@ -114,6 +114,19 @@ public void testRegexpMatches()