Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/541
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r71585214
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
@@ -106,36 +106,43 @@ public PhysicalPlan getPlan(SqlN
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r71585003
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableIfExistsHandler.java
---
@@ -28,47 +30,57 @@
import org.apach
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r71583345
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableIfExistsHandler.java
---
@@ -28,47 +30,57 @@
import org.apach
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70342391
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableIfExistsHandler.java
---
@@ -28,47 +30,57 @@
import org
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70342372
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
@@ -106,36 +106,43 @@ public PhysicalPlan getPla
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70340564
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableIfExistsHandler.java
---
@@ -28,47 +30,57 @@
import org
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70230071
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java ---
@@ -591,4 +591,27 @@ public void
showProperMsgWhenTryingToDropANonV
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70230053
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestDropTable.java
---
@@ -171,4 +175,45 @@ public void testDropOnImmutableSchema() throws
Exception
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70229922
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestDropTable.java
---
@@ -19,14 +19,18 @@
import org.apache.drill.common.exceptions.UserEx
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70153763
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropTable.java
---
@@ -92,4 +105,6 @@ public SqlIdentifier getTableIdentif
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70153568
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropTable.java
---
@@ -57,13 +63,20 @@ public SqlOperator getOperator() {
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70153513
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -69,6 +71,15 @@ public PhysicalPlan getPlan(Sq
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70153040
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -69,6 +71,15 @@ public PhysicalPlan getPlan(Sq
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70099210
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -245,15 +247,17 @@ SqlNode SqlCreateTable() :
* Parses a drop table statement.
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70098588
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -199,15 +199,17 @@ SqlNode SqlCreateOrReplaceView() :
* Parses a drop view stat
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70098841
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestInbuiltHiveUDFs.java
---
@@ -84,4 +84,10 @@ public void testGetJsonObject
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69995961
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -69,6 +71,15 @@ public PhysicalPlan getP
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69995586
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -69,6 +71,15 @@ public PhysicalPlan getP
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69994120
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java ---
@@ -591,4 +591,27 @@ public void
showProperMsgWhenTryingToDro
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993981
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestDropTable.java
---
@@ -171,4 +175,45 @@ public void testDropOnImmutableSchema() throws
Exce
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993147
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropTable.java
---
@@ -57,13 +63,20 @@ public SqlOperator getOperato
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993161
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropTable.java
---
@@ -92,4 +105,6 @@ public SqlIdentifier getTableI
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993129
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -69,6 +71,15 @@ public PhysicalPlan getP
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993188
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestDropTable.java
---
@@ -19,14 +19,18 @@
import org.apache.drill.common.exceptions.
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993113
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestInbuiltHiveUDFs.java
---
@@ -84,4 +84,10 @@ public void testGetJson
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69991686
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -199,15 +199,17 @@ SqlNode SqlCreateOrReplaceView() :
* Parses a drop vie
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69991381
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -245,15 +247,17 @@ SqlNode SqlCreateTable() :
* Parses a drop table state
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69991328
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -199,15 +199,17 @@ SqlNode SqlCreateOrReplaceView() :
* Parses a drop vie
GitHub user vdiravka opened a pull request:
https://github.com/apache/drill/pull/541
DRILL-4673: Implement "DROP TABLE IF EXISTS" for drill to prevent FAIâ¦
â¦LED status on command return
- implement DROP TABLE IF EXISTS and DROP VIEW IF EXISTS;
- added unit test for D
30 matches
Mail list logo
