[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98288738 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -426,6 +459,7 @@ public void set

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98288632 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -399,9 +430,11 @@ public void se

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98289161 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java --- @@ -179,10 +189,10 @@ private int getN

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98288871 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/BufferedDirectBufInputStream.java --- @@ -43,7 +45,7 @@ private

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98268266 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java --- @@ -41,26 +42,33 @@ import java.io

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98272441 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java --- @@ -282,89 +356,119 @@ public synchroni

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98288225 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -197,6 +213,21 @@ public Parquet

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98269860 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java --- @@ -74,12 +82,17 @@ protected void load

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98269966 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java --- @@ -109,17 +122,30 @@ private DrillBuf

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98271891 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java --- @@ -282,89 +356,119 @@ public synchroni

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98270983 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java --- @@ -176,12 +202,29 @@ private DrillBuf

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98269034 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java --- @@ -41,26 +42,33 @@ import java.io

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98271038 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java --- @@ -192,45 +235,74 @@ private DrillBuf

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98268204 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java --- @@ -41,26 +42,33 @@ import java.io

[GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/723#discussion_r98289478 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/filereader/DirectBufInputStream.java --- @@ -81,7 +87,15 @@ public synchronized int rea