[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/749 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-23 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/749#discussion_r102827651 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java --- @@ -70,33 +87,21 @@ public long readField

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-23 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/749#discussion_r102830312 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java --- @@ -33,35 +33,52 @@ ParquetRecordR

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-23 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/749#discussion_r102826142 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java --- @@ -33,35 +33,52 @@ ParquetRecordR

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-23 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/749#discussion_r102824318 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -351,7 +353,7 @@ public void setup(Op

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-23 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/749#discussion_r102812251 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java --- @@ -70,33 +70,31 @@ public long read

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-23 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/749#discussion_r102809909 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -376,14 +378,14 @@ public void s

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-23 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/749#discussion_r102809881 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -73,6 +72,7 @@ private st

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-23 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/749#discussion_r102726705 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java --- @@ -70,33 +70,31 @@ public long readField

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-23 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/749#discussion_r102725896 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -376,14 +378,14 @@ public void setup(

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-23 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/749#discussion_r102726321 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -73,6 +72,7 @@ private static

[GitHub] drill pull request #749: DRILL-5266: Parquet returns low-density batches

2017-02-17 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/749 DRILL-5266: Parquet returns low-density batches Fixes one glaring problem related to bit/byte confusion. Includes a few clean-up items found along the way. You can merge this pull reques