[GitHub] ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax

2018-11-12 Thread GitBox
ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#issuecomment-437823918 Hi @amansinha100 , thanks for approving the PR and sorry for confusing comment about rule ordering. I've added documentation note under jira issue.

[GitHub] ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax

2018-11-09 Thread GitBox
ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#issuecomment-437388664 I noticed that this issue with aggregate and low slice target doesn't relate only to cross-join queries. As a workaround we can bypass unsuccessful

[GitHub] ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax

2018-10-31 Thread GitBox
ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#issuecomment-434703183 Hi @amansinha100 . Thanks for your active involvement, I investigated the issue and found that: when option `planner.slice_target` is set to

[GitHub] ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax

2018-10-16 Thread GitBox
ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#issuecomment-430249450 > @ihuzenko I have a minor comment about the error message (sorry I just noticed it when I was about to merge your PR). If you can address it, I will

[GitHub] ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax

2018-10-05 Thread GitBox
ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#issuecomment-427331814 @HanumathRao I've addressed comments, please take a look. This is an automated