[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-08-30 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-417542094 @sohami applied your review comments.

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-08-27 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-416376865 @sohami I have repurposed DRILL-5365 to focus only on documenting and enforcing the immutabili

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-20 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-406743060 @sohami Thanks for saving the day on this PR and pointing out the issues before the changes go

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-20 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-406714398 @sohami I unit tested setDeprecatedProperties which you suggested. It does exactly what is nee

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-19 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-406449788 @arina-ielchiieva @sohami Replied to comments. Please let me know if you have more comments.

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-404977655 @vdiravka addressed your comments, and I pushed a few more changes after your last pass. I ad

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-404976675 Created a jira for the HiveDrillNativeParquetRowGroupScan issue here https://issues.apache.org

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-404975183 For some reason github won't let me respond next to one of your comments, so putting response

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-03 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-402292968 I also forgot to mention a third possible bug, which is that FileSystemConfigurations defined

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-03 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-402292010 ## Problem @paul-rogers @vdiravka I have an update. Chun was unable to reproduce the is