jnturton commented on PR #2867:
URL: https://github.com/apache/drill/pull/2867#issuecomment-1882408865
> @cgivre, the `.asf.yaml` file you mentioned has lots of metadata, but does
not actually prevent a force push. Perhaps we are missing something? It would
generally be a good idea to
cgivre commented on PR #2867:
URL: https://github.com/apache/drill/pull/2867#issuecomment-1882148031
> I successfully squashed the commits, and provided a proper commit message,
while preserving the later commit. Did a force push to master to rewrite
history.
>
> You should update
paul-rogers commented on PR #2867:
URL: https://github.com/apache/drill/pull/2867#issuecomment-1881965757
I successfully squashed the commits, and provided a proper commit message,
while preserving the later commit. Did a force push to master to rewrite
history.
You should update
cgivre commented on code in PR #2867:
URL: https://github.com/apache/drill/pull/2867#discussion_r1444727956
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderUnprojected.java:
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache
jnturton commented on code in PR #2867:
URL: https://github.com/apache/drill/pull/2867#discussion_r1444618000
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderUnprojected.java:
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache
jnturton commented on code in PR #2867:
URL: https://github.com/apache/drill/pull/2867#discussion_r1444618000
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderUnprojected.java:
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache
paul-rogers commented on PR #2867:
URL: https://github.com/apache/drill/pull/2867#issuecomment-1880502847
Backporting should be safe: as safe as having the change in master itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
paul-rogers commented on code in PR #2867:
URL: https://github.com/apache/drill/pull/2867#discussion_r1444244003
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderUnprojected.java:
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the
jnturton commented on PR #2867:
URL: https://github.com/apache/drill/pull/2867#issuecomment-1880450409
I think we can regard this as a bug fix to framework code already present in
1.21 and therefore backport it.
--
This is an automated message from the Apache Git Service.
To respond to
jnturton commented on code in PR #2867:
URL: https://github.com/apache/drill/pull/2867#discussion_r1444185697
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderUnprojected.java:
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache
cgivre commented on code in PR #2867:
URL: https://github.com/apache/drill/pull/2867#discussion_r1444180941
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderUnprojected.java:
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache
jnturton commented on code in PR #2867:
URL: https://github.com/apache/drill/pull/2867#discussion_r1444180526
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderUnprojected.java:
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache
jnturton commented on code in PR #2867:
URL: https://github.com/apache/drill/pull/2867#discussion_r1444180526
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderUnprojected.java:
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache
paul-rogers commented on code in PR #2867:
URL: https://github.com/apache/drill/pull/2867#discussion_r1444117648
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderUnprojected.java:
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the
luocooong commented on code in PR #2867:
URL: https://github.com/apache/drill/pull/2867#discussion_r1444101786
##
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderUnprojected.java:
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache
paul-rogers merged PR #2867:
URL: https://github.com/apache/drill/pull/2867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
paul-rogers commented on PR #2867:
URL: https://github.com/apache/drill/pull/2867#issuecomment-1880146814
Thanks @cgivre for the comments and review. @luocooong, I'll commit this.
When convenient, please see if this addresses the issue you raised long ago.
Otherwise, these capabilities are
cgivre commented on PR #2867:
URL: https://github.com/apache/drill/pull/2867#issuecomment-1879917039
Once we merge this, we should also rebase
https://github.com/apache/drill/pull/2515 on the current master and merge that
as well.
--
This is an automated message from the Apache Git
paul-rogers opened a new pull request, #2867:
URL: https://github.com/apache/drill/pull/2867
# Support for non-projected complex vectors
## Description
The EVF mechanism provides scan-time projection for many vector types. The
reader code is simple: it deserializes all columns
19 matches
Mail list logo
