cgivre merged PR #2819:
URL: https://github.com/apache/drill/pull/2819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
jnturton commented on PR #2819:
URL: https://github.com/apache/drill/pull/2819#issuecomment-1686562600
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
cgivre commented on PR #2819:
URL: https://github.com/apache/drill/pull/2819#issuecomment-1686494732
@mbeckerle @jnturton Are we ok to merge this? I'll add support for arrays
in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
cgivre commented on code in PR #2819:
URL: https://github.com/apache/drill/pull/2819#discussion_r1299285670
##
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpXmlOptions.java:
##
@@ -111,7 +111,7 @@ public String toString() {
public static class
mbeckerle commented on code in PR #2819:
URL: https://github.com/apache/drill/pull/2819#discussion_r1298815764
##
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpXmlOptions.java:
##
@@ -111,7 +111,7 @@ public String toString() {
public static class
cgivre commented on PR #2819:
URL: https://github.com/apache/drill/pull/2819#issuecomment-1684011222
@mbeckerle Could you please take another look. I had to fix a few things
for a unit test. Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message,
cgivre commented on PR #2819:
URL: https://github.com/apache/drill/pull/2819#issuecomment-1676572517
@mbeckerle Unit tests fixed. I also added the data type inference for APIs
that generate XML.
@jnturton, The CI is still failing with that Kerberos issue.
--
This is an automated
cgivre commented on PR #2819:
URL: https://github.com/apache/drill/pull/2819#issuecomment-1673416654
Converting to draft. There's a unit test failing in the HTTP plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mbeckerle commented on code in PR #2819:
URL: https://github.com/apache/drill/pull/2819#discussion_r1287322034
##
common/src/main/java/org/apache/drill/common/Typifier.java:
##
@@ -88,6 +96,40 @@ public class Typifier {
// If a String contains any of these, try to evaluate
cgivre commented on code in PR #2819:
URL: https://github.com/apache/drill/pull/2819#discussion_r1287295957
##
common/src/main/java/org/apache/drill/common/Typifier.java:
##
@@ -88,6 +96,40 @@ public class Typifier {
// If a String contains any of these, try to evaluate it
mbeckerle commented on code in PR #2819:
URL: https://github.com/apache/drill/pull/2819#discussion_r1287251884
##
contrib/format-xml/README.md:
##
@@ -15,12 +15,15 @@ The default configuration is shown below:
"extensions": [
"xml"
],
+ "allTextMode": true,
cgivre opened a new pull request, #2819:
URL: https://github.com/apache/drill/pull/2819
# [DRILL-8450](https://issues.apache.org/jira/browse/DRILL-8450): Add Data
Type Inference to XML Format Plugin
## Description
This PR adds data type inference to the XML format plugin
12 matches
Mail list logo
