回复:[VOTE] Add LGTM to Drill Pull Requests

2021-08-31 Thread 王腾飞(飞腾)
+1 -- 发件人:Jason Altekruse 发送时间:2021年8月31日(星期二) 19:22 收件人:dev 主 题:Re: [VOTE] Add LGTM to Drill Pull Requests +1 On Tue, Aug 31, 2021, 2:44 AM James Turton wrote: > If there are no unpleasant side effects then it sounds lik

Re: [VOTE] Add LGTM to Drill Pull Requests

2021-08-31 Thread Jason Altekruse
+1 On Tue, Aug 31, 2021, 2:44 AM James Turton wrote: > If there are no unpleasant side effects then it sounds like a good idea > to me +1. > > On 2021/08/30 23:23, Charles Givre wrote: > > Hello Drill Devs, > > I’d like to call a vote as to whether we add LGTM automated code check > to our pull

Re: [VOTE] Add LGTM to Drill Pull Requests

2021-08-31 Thread James Turton
If there are no unpleasant side effects then it sounds like a good idea to me +1. On 2021/08/30 23:23, Charles Givre wrote: Hello Drill Devs, I’d like to call a vote as to whether we add LGTM automated code check to our pull requests. This would not replace the current review process, but ra

Re: [VOTE] Add LGTM to Drill Pull Requests

2021-08-30 Thread luoc
+1 > 在 2021年8月31日,05:23,Charles Givre 写道: > > Hello Drill Devs, > I’d like to call a vote as to whether we add LGTM automated code check to our > pull requests. This would not replace the current review process, but > rather add a quality check to new code. I seem to recall us voting on

[VOTE] Add LGTM to Drill Pull Requests

2021-08-30 Thread Charles Givre
Hello Drill Devs, I’d like to call a vote as to whether we add LGTM automated code check to our pull requests. This would not replace the current review process, but rather add a quality check to new code. I seem to recall us voting on this before, but I couldn’t find the email, so I apologi