Boaz Ben-Zvi created DRILL-6888: ----------------------------------- Summary: Nested classes in HashAggTemplate break the plain Java for debugging codegen Key: DRILL-6888 URL: https://issues.apache.org/jira/browse/DRILL-6888 Project: Apache Drill Issue Type: Improvement Components: Execution - Relational Operators Affects Versions: 1.14.0 Reporter: Boaz Ben-Zvi Assignee: Boaz Ben-Zvi
The *prefer_plain_java* compile option is useful for debugging of generated code. DRILL-6719 ("separate spilling logic for Hash Agg") introduced two nested classes into the HashAggTemplate class. However those nested classes cause the prefer_plain_java compile option to fail when compiling the generated code, like: {code:java} Error: SYSTEM ERROR: CompileException: File '/tmp/janino5709636998794673307.java', Line 36, Column 35: No applicable constructor/method found for actual parameters "org.apache.drill.exec.test.generated.HashAggregatorGen11$HashAggSpilledPartition"; candidates are: "protected org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate$BatchHolder org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate.injectMembers(org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate$BatchHolder)" {code} +The proposed fix+: Move those nested classes outside HashAgTemplate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)