Re: Help for DRILL-3609

2019-11-08 Thread Nitin Pawar
Thanks for the links and guidance Paul. I will use your advice and see if I can get past the limitation. Thanks, Nitin On Thu, Nov 7, 2019 at 1:00 PM Paul Rogers wrote: > Hi Nitin, > > As it turns out, I just had to fix a bug in the windowing operator. I'm > not an expert on this operator,

Re: Help for DRILL-3609

2019-11-06 Thread Paul Rogers
Hi Nitin, As it turns out, I just had to fix a bug in the windowing operator. I'm not an expert on this operator, but perhaps I can offer a suggestion or two. We have a few existing unit tests for window functions in TestWindowFrame. They are a bit hard to follow, however. Take a look at

Re: Help for DRILL-3609

2019-11-06 Thread Nitin Pawar
any help on this? On Tue, Nov 5, 2019 at 7:09 PM Nitin Pawar wrote: > Ohh ok > let me provide a google drive url > Here > > is the link. Can you check if can access it. > > Thanks, > Nitin > > On Tue, Nov 5,

Re: Help for DRILL-3609

2019-11-05 Thread Nitin Pawar
Ohh ok let me provide a google drive url Here is the link. Can you check if can access it. Thanks, Nitin On Tue, Nov 5, 2019 at 7:02 PM Charles Givre wrote: > Hi Nitin, > It seems to have been filtered out. >

Re: Help for DRILL-3609

2019-11-05 Thread Charles Givre
Hi Nitin, It seems to have been filtered out. > On Nov 5, 2019, at 8:29 AM, Nitin Pawar wrote: > > Hi Charles, > > I have attached git patch. > I was currently doing for lag function only for testing purposes > > Thanks, > Nitin > > On Tue, Nov 5, 2019 at 6:34 PM Charles Givre

Re: Help for DRILL-3609

2019-11-05 Thread Nitin Pawar
Hi Charles, I have attached git patch. I was currently doing for lag function only for testing purposes Thanks, Nitin On Tue, Nov 5, 2019 at 6:34 PM Charles Givre wrote: > Hi Nitin, > Thanks for your question. Could you/did you share your code? If not, > could you please post a draft PR so

Re: Help for DRILL-3609

2019-11-05 Thread Charles Givre
Hi Nitin, Thanks for your question. Could you/did you share your code? If not, could you please post a draft PR so that we can take a look and offer suggestions? Thanks, -- C > On Nov 5, 2019, at 7:27 AM, Nitin Pawar wrote: > > Hi Devs, > > I had sent request for this almost 2.5 years

Help for DRILL-3609

2019-11-05 Thread Nitin Pawar
Hi Devs, I had sent request for this almost 2.5 years ago. Trying it again now. Currently Apache drill window functions LEAD and LAG support offset as 1. In another words in a given window these functions can return either previous or next row only. I am trying modify the behavior these

Re: Help for DRILL-3609

2017-04-10 Thread Nitin Pawar
Hi devs, can someone help me on this ? Thanks, Nitin On Mon, Apr 3, 2017 at 11:29 AM, Nitin Pawar wrote: > Hi Aman, > > I have committed my code at https://github.com/nitinpawar/drill > > When I say that results are crossing partition boundary, i meant when i > say

Re: Help for DRILL-3609

2017-04-03 Thread Nitin Pawar
Hi Aman, I have committed my code at https://github.com/nitinpawar/drill When I say that results are crossing partition boundary, i meant when i say partition by department_id, for department_id = 1 partitionProcessor considers records from department_id=2 Here is the result of sample query. If

Re: Help for DRILL-3609

2017-03-31 Thread Aman Sinha
Hi Nitin, When you say ‘it is crossing the partition boundary’, it’s not clear what precisely are you are referring to. Window function operator semantics are somewhat complex, so pls clarify. Usually it is more effective to put your investigation and even a link to your github branch

Re: Help for DRILL-3609

2017-03-31 Thread Nitin Pawar
anyone who can spare 10-15 minutes ? Thanks, Nitin On Mon, Mar 27, 2017 at 3:56 PM, Nitin Pawar wrote: > Hi, > > I am working DRILL-3609 > > Right now I have been able to change the hard coded offset to the value >

Help for DRILL-3609

2017-03-27 Thread Nitin Pawar
Hi, I am working DRILL-3609 Right now I have been able to change the hard coded offset to the value user inputs. I have successfully ran the query. I am currently stuck where it is crossing the partition boundary. In the current implementation