Re: Implicit columns and maps

2017-10-30 Thread Paul Rogers
Hi Jinfeng, Thanks much for your thoughts. To follow up on two topics. First, how would you suggest we handle the following: SELECT user, filename, `filename` FROM … Here, the project list handed to the scan operator will have three columns, two with name “filename”. I suppose we’d need to mod

Re: Implicit columns and maps

2017-10-27 Thread Jinfeng Ni
I think it would make sense to treat the implicit columns as reserved words, and if user wants to use those names as regular column, or table name, or any objects in the system, they should use quoted identifier. select suffix from t1; // implicit columns takes precedence select `suffix` from t1;

Re: Implicit columns and maps

2017-10-09 Thread Paul Rogers
As you point out, naming is a separate issue. I believe we inherited names from some other system. But, it is an issue that we use “good” names for implicit columns. If we add more names “createDate”, “modifcationDate”, “owner”, or whatever), we end up breaking someone’s queries that has columns

Re: Implicit columns and maps

2017-10-09 Thread Boaz Ben-Zvi
How about changing all those “implicit” columns to have some “unconventional” prefix, like an underscore (or two _ _ ); e.g. _suffix, _dir0, etc . With such a change we may need to handle the transition of existing users’ code ; e.g., maybe change the priority (mentioned below) so that an e

Implicit columns and maps

2017-10-09 Thread Paul Rogers
Hi All, Drill provides a set of “implicit” columns to describe files: filename, suffix, fan and filepath. Drill also provides an open-ended set of partition columns: dir0, dir1, dir2, etc. Not all readers support the above: some do and some don’t. Drill semantics seem to treat these as semi-re