Hey all,
What does everyone think about Weijie’s suggestion? We’ve been turning the
“plain Java” option on in an ad-hoc fashion for debugging now for about a year
and have never seen an issue. Indeed, no issue would be expected since the
“plain Java” technique just generates and compiles Java c
@paul why not set the default code generation be plain java? The current
default ASM merge method will have some unpredictable scalar replacement
errors which we ever suffered before. This will give users trustless feal.
What the merging does will also be done by the JIT if we choose the plain
jav
@chunhui we just adjust different compiler options ,the generating code
strategy does not affected by the compiler option. so I think the
different result just reflects the compiler's performance.
On Wed, Aug 2, 2017 at 1:45 AM, Chunhui Shi wrote:
>
> Correct my previous response:
>
> In DRILL
Correct my previous response:
In DRILL-4778, JDK was faster in compilation but generated slower code. Janino
was slower in compilation and generate faster code. Your JIRA did not mention
how was the performance when running generated code. You may want to test this
aspect as well.
From: weij
don't see any
reason we need Janino for any case.
From: weijie tong
Sent: Monday, July 31, 2017 8:31:41 AM
To: dev@drill.apache.org
Subject: Re: Which code compiler is better
here is JIRA link : https://issues.apache.org/jira/browse/DRILL-5696
Our pr
performance, and avoid the step of writing code
> to disk, use the following instead:
>
> cg.preferPlainJava(true);
>
> More details appears in [1].
>
> Thanks,
>
> - Paul
>
> [1] https://github.com/paul-rogers/drill/wiki/Code-
> Generation-and-%22Short%2C-F
//github.com/paul-rogers/drill/wiki/Code-Generation-and-%22Short%2C-Fat%22-Queries
From: Aman Sinha
Sent: Sunday, July 30, 2017 9:16:09 AM
To: dev@drill.apache.org
Subject: Re: Which code compiler is better
Weijie,
what is the size (in KB) of your generated code
Weijie,
what is the size (in KB) of your generated code for the aggregate operator
that is doing the 20 SUM/AVG ? Also, what JDK version are you using ?
>From what I recall, Janino was faster than JDK 1.7 up to about 256 KB
source code file. That's the current threshold in Drill; if the size is
