Re: Review Request 29648: DRILL-1874: Text reader should allow treating empty fields as NULLs instead of empty string

2015-01-09 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29648/#review67569 --- Ship it! Looks like you've made the suggested changes in your githu

Re: Review Request 29648: DRILL-1874: Text reader should allow treating empty fields as NULLs instead of empty string

2015-01-08 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29648/#review67349 --- exec/java-exec/src/main/codegen/data/Casts.tdd

Re: Review Request 29648: DRILL-1874: Text reader should allow treating empty fields as NULLs instead of empty string

2015-01-08 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29648/ --- (Updated Jan. 9, 2015, 12:14 a.m.) Review request for drill, Aman Sinha and Jin

Re: Review Request 29648: DRILL-1874: Text reader should allow treating empty fields as NULLs instead of empty string

2015-01-08 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29648/#review67284 --- common/src/main/java/org/apache/drill/common/expression/fn/CastFunc

Re: Review Request 29648: DRILL-1874: Text reader should allow treating empty fields as NULLs instead of empty string

2015-01-08 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29648/ --- (Updated Jan. 8, 2015, 6:25 p.m.) Review request for drill, Aman Sinha and Jinf

Re: Review Request 29648: DRILL-1874: Text reader should allow treating empty fields as NULLs instead of empty string

2015-01-07 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29648/#review67029 --- A few comments: - We should also support casting empty string to D

Re: Review Request 29648: DRILL-1874: Text reader should allow treating empty fields as NULLs instead of empty string

2015-01-06 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29648/ --- (Updated Jan. 7, 2015, 2:12 a.m.) Review request for drill, Aman Sinha and Jinf

Review Request 29648: DRILL-1874: Text reader should allow treating empty fields as NULLs instead of empty string

2015-01-06 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29648/ --- Review request for drill, Aman Sinha and Jinfeng Ni. Bugs: DRILL-1874 https