Re: Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-30 Thread Chris Westin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29723/#review70376 --- exec/java-exec/src/main/codegen/templates/FixedValueVectors.java

Re: Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-22 Thread Hanifi Gunes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29723/#review69296 --- Ship it! Ship It! - Hanifi Gunes On Jan. 22, 2015, 9:40 p.m., St

Re: Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-22 Thread Steven Phillips
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29723/ --- (Updated Jan. 22, 2015, 9:40 p.m.) Review request for drill, Hanifi Gunes and J

Re: Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-20 Thread Hanifi Gunes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29723/#review68854 --- exec/java-exec/src/main/codegen/templates/MapWriters.java

Re: Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-19 Thread Steven Phillips
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29723/ --- (Updated Jan. 20, 2015, 2:44 a.m.) Review request for drill, Hanifi Gunes and J

Re: Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-19 Thread Steven Phillips
> On Jan. 17, 2015, 2:38 a.m., Jason Altekruse wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java, > > line 621 > > > > > > Doesn't this line ensure we have a pos

Re: Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-19 Thread Steven Phillips
> On Jan. 19, 2015, 4:56 p.m., Jason Altekruse wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/CopyUtil.java, > > line 39 > > > > > > As in the other cases, this should be encapsualted to allow lat

Re: Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-19 Thread Steven Phillips
> On Jan. 19, 2015, 4:56 p.m., Jason Altekruse wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java, > > line 95 > > > > > > Do we really want this to defaul

Re: Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-19 Thread Jason Altekruse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29723/#review68625 --- exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/co

Re: Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-16 Thread Jason Altekruse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29723/#review68495 --- contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hba

Review Request 29723: DRILL-1960: Automatically realloc buffers when vector runs out of space

2015-01-08 Thread Steven Phillips
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29723/ --- Review request for drill and Jacques Nadeau. Repository: drill-git Descriptio